Variable Climbing sound #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested it without flying and I like it. I would still export the setting into VarioSettings.h so that the end-user can easily configure it. |
|
That's not a bad idea! I guess I put it in beeper.h because that's where the other sound settings were. anyhow it's up to @prunkdump to decide ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Baptiste, I see that in aa9d997822746be28f4f0cfbc94a897504288c03 You implemented the variable sinking beep, but not the variable climbing beep. I wonder if you tested it and were just unhappy with the change, or for any other reason?
My patch did not break or changed the previous behaviour, but it added functionality - being able to set a climbing beep that is varying in frequency during a beep, or keeping the monotonous beep. I think many (if not most?) varios use a varying frequency beep. and I find it a lot more informative as I don't need to wait for the next beep to understand the variance in climb rate since the current beep started.
Do you think otherwise?
I made a branch that merges with no errors for you to test. please note that for your default behavior you need to change the
#define CLIMBING_BEEP_FREQ_UPDATEback to 0.#define CLIMBING_BEEP_FREQ_UPDATE 1 // update climbing beep frequency(pitch) after X milliseconds. 0 = monotonous beep, do not update frequency while beep is playing. 1 = pitch changes smoothly every 1ms. more than 1 = pitch changed in steps every X milliseconds.